Propagate function symbol name as base for air.segment symbol name #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwei-xilinx
approved these changes
Jun 3, 2024
fifield
added a commit
to fifield/mlir-air
that referenced
this pull request
Jun 4, 2024
fifield
added a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current air.segment symbol naming logic makes sure that we don't end up with the same symbol name for air.segments in a given module. But the symbols can still be same across different modules. This can be a problem if we want to merge functions from multiple modules into one. In this PR we use the symbol name of the function enclosing the air.segment op as the base name. This way such conflicts wont happen assuming the function names are unique.