-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIRFuseChannels: A number of hotfixes #683
Merged
erwei-xilinx
merged 14 commits into
Xilinx:main
from
erwei-xilinx:relaxed_unnecessary_cond_for_chan_fusion
Jul 30, 2024
Merged
AIRFuseChannels: A number of hotfixes #683
erwei-xilinx
merged 14 commits into
Xilinx:main
from
erwei-xilinx:relaxed_unnecessary_cond_for_chan_fusion
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
erwei-xilinx
commented
Jul 26, 2024
- In non-aggressive mode, relax the check that puts to the two channels (to be fused) must have the same offsets, wraps and strides. This is because if the get side share the exact same destination, then the two channels must be fused, otherwise there is going to be a race condition, where multiple DMA channels are writing to the same destination.
- In aggressive mode, fixup a couple of places where channel's original ordering in the code wasn't respected.
erwei-xilinx
changed the title
AIRChannelFusion: A number of hotfixes
AIRFuseChannels: A number of hotfixes
Jul 26, 2024
…from AIRFuseChannels
…annels have been corrected
…laxed_unnecessary_cond_for_chan_fusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.