Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIRFuseChannels: A number of hotfixes #683

Merged

Conversation

erwei-xilinx
Copy link
Collaborator

  • In non-aggressive mode, relax the check that puts to the two channels (to be fused) must have the same offsets, wraps and strides. This is because if the get side share the exact same destination, then the two channels must be fused, otherwise there is going to be a race condition, where multiple DMA channels are writing to the same destination.
  • In aggressive mode, fixup a couple of places where channel's original ordering in the code wasn't respected.

@erwei-xilinx erwei-xilinx changed the title AIRChannelFusion: A number of hotfixes AIRFuseChannels: A number of hotfixes Jul 26, 2024
@erwei-xilinx erwei-xilinx marked this pull request as ready for review July 30, 2024 19:58
@erwei-xilinx erwei-xilinx enabled auto-merge (squash) July 30, 2024 20:03
@erwei-xilinx erwei-xilinx merged commit a913d16 into Xilinx:main Jul 30, 2024
19 checks passed
@erwei-xilinx erwei-xilinx deleted the relaxed_unnecessary_cond_for_chan_fusion branch July 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant