Add support for correctly generating dependency graph with reshape/expand/collapse shape ops in the code #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hape/expand/collapse ops exist
akkothar
changed the title
erwei-xilinx
reviewed
Aug 8, 2024
erwei-xilinx
reviewed
Aug 8, 2024
erwei-xilinx
approved these changes
Aug 8, 2024
hunhoffe
pushed a commit
that referenced
this pull request
Aug 12, 2024
…pand/collapse shape ops in the code (#698) * Add support for handling reshape/expand/collapse shape ops * Correctly generate dependency graphs in presence of shape altering ops * Ensure that the dependencies are correctly established with shape-altering codes * Remove debug prints * Fix format * Fix format * fix format and remove debug prints * Add test to ensure dependency tokens are generated correctly when reshape/expand/collapse ops exist * Remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ops such as reshape, expand and collapse shape do not execute, and these ops affect the dependence graph. This pull request attempts to handle these ops correctly and make sure the dependence graph is generated correctly when these ops are lingering around in the code.