Support changing the function calls replacing linalg ops in presence of reshape ops #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
reviewed
Aug 7, 2024
erwei-xilinx
approved these changes
Aug 7, 2024
erwei-xilinx
reviewed
Aug 8, 2024
mlir/lib/Conversion/AIRToAIEPass.cpp
Outdated
| @@ -3511,7 +3531,7 @@ FailureOr<ModuleOp> convertAIRToAIE(mlir::RewriterBase &rewriter, | |||
| /* .device = */ *device}; | |||
| std::vector<std::pair<ModuleOp, xilinx::air::HerdOp>> aie_modules; | |||
| p.walk([&](xilinx::air::HerdOp h) { | |||
| aie_modules.push_back({aie_module, h}); | |||
There was a problem hiding this comment.
Clang format error points to this. Change this back to the original format
hunhoffe
pushed a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes signature of calls to library functions in presence of reshape/expand/collapse ops. This is important because no other way of lowering support such ops currently exists, and this is a way of getting rid of them before generating code for AIEs.