Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly generate offsets for DMA memcpys for AIEs #713

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

akkothar
Copy link
Contributor

This pull request has the following modifications:

  • Generating correct offsets in situations where layouts are in some blocked format.
  • Correctly splitting DMA memcpys: an extra add instruction was being generated when correcting offsets after splitting memcpys.

@akkothar akkothar marked this pull request as draft August 15, 2024 19:09
@akkothar akkothar changed the title Correctly generate offsets for DMA copies for AIEs Correctly generate offsets for DMA memcpys for AIEs Aug 15, 2024
@erwei-xilinx
Copy link
Collaborator

@akkothar, would it be possible if you could add your blocked GEMM e2e example as a board test in mlir-air, under test/xrt? So that in our future development we do not break the design.

@akkothar
Copy link
Contributor Author

@akkothar, would it be possible if you could add your blocked GEMM e2e example as a board test in mlir-air, under test/xrt? So that in our future development we do not break the design.

Yeah, I am about to create separate PRs for some tests so you can decide what tests you want to add because I have multiple tests on my end.

@akkothar akkothar marked this pull request as ready for review August 15, 2024 23:58
Copy link
Collaborator

@erwei-xilinx erwei-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this fix. This is really neat.

@erwei-xilinx erwei-xilinx merged commit 74d1b73 into Xilinx:main Aug 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants