📝 remove needless allow

src/cancel.rs

@@ -35,7 +35,6 @@ pub trait CancelIo {
     type Data;
     fn new() -> Self;
     // set the io data
-    #[allow(dead_code)]
     fn set(&self, io_data: Self::Data);
     // clear the io data
     fn clear(&self);

src/coroutine_impl.rs

@@ -90,9 +90,8 @@ impl EventSource for Done {
 pub type CoroutineImpl = Generator<'static, EventResult, EventSubscriber>;
 
 #[inline]
-#[allow(clippy::cast_ptr_alignment)]
 fn get_co_local(co: &CoroutineImpl) -> *mut CoroutineLocal {
-    co.get_local_data() as *mut CoroutineLocal
+    co.get_local_data().cast()
 }
 
 ////////////////////////////////////////////////////////////////////////////////

src/io/sys/windows/co_io.rs

@@ -64,11 +64,10 @@ impl<T: AsRawHandle> CoIo<T> {
         }
     }
 
-    /// reset internal io data
-    #[allow(dead_code)]
-    pub(crate) fn io_reset(&self) {
-        self.io.reset()
-    }
+    // /// reset internal io data
+    // pub(crate) fn io_reset(&self) {
+    //     self.io.reset()
+    // }
 
     /// get inner ref
     #[inline]
@@ -177,6 +176,7 @@ mod tests {
 
         impl AsRawHandle for Hd {
             fn as_raw_handle(&self) -> RawHandle {
+                // this is a fake handle, can't run!
                 0 as _
             }
         }

src/io/sys/windows/iocp.rs

@@ -1,6 +1,5 @@
 use std::cell::UnsafeCell;
 use std::os::windows::io::AsRawSocket;
-#[cfg(feature = "io_timeout")]
 use std::time::Duration;
 use std::{io, ptr};
 

src/io/sys/windows/miow.rs

@@ -782,9 +782,9 @@ impl SocketAddrBuf {
     /// address filled in and return the standard socket address type.
     ///
     /// If an error is encountered then `None` is returned.
-    #[allow(clippy::wrong_self_convention)]
-    pub fn to_socket_addr(&self) -> Option<SocketAddr> {
-        unsafe { ptrs_to_socket_addr(&self.buf as *const _ as *const _, self.len) }
+    pub fn get_socket_addr(&self) -> Option<SocketAddr> {
+        let ptr = (&self.buf as *const SOCKADDR_STORAGE).cast();
+        unsafe { ptrs_to_socket_addr(ptr, self.len) }
     }
 }
 

src/io/sys/windows/mod.rs

@@ -6,6 +6,7 @@ macro_rules! co_try {
                 let mut co = $co;
                 crate::yield_now::set_co_para(&mut co, err);
                 $s.schedule(co);
+                #[allow(clippy::needless_return)]
                 return;
             }
         }

src/io/sys/windows/net/socket_write.rs

@@ -41,7 +41,6 @@ impl<'a> SocketWrite<'a> {
 }
 
 impl EventSource for SocketWrite<'_> {
-    #[allow(clippy::needless_return)]
     fn subscribe(&mut self, co: CoroutineImpl) {
         let s = get_scheduler();
         #[cfg(feature = "io_timeout")]

src/io/sys/windows/net/udp_recv_from.rs

@@ -43,7 +43,7 @@ impl<'a> UdpRecvFrom<'a> {
 
     pub fn done(&mut self) -> io::Result<(usize, SocketAddr)> {
         let size = co_io_result(&self.io_data, self.is_coroutine)?;
-        let addr = self.addr.to_socket_addr().ok_or_else(|| {
+        let addr = self.addr.get_socket_addr().ok_or_else(|| {
             io::Error::new(io::ErrorKind::Other, "could not obtain remote address")
         })?;
         Ok((size, addr))

src/io/sys/windows/net/udp_send_to.rs

@@ -47,7 +47,6 @@ impl<'a> UdpSendTo<'a> {
 }
 
 impl EventSource for UdpSendTo<'_> {
-    #[allow(clippy::needless_return)]
     fn subscribe(&mut self, co: CoroutineImpl) {
         let s = get_scheduler();
         #[cfg(feature = "io_timeout")]

src/io/sys/windows/pipe/pipe_write.rs

@@ -40,7 +40,6 @@ impl<'a> PipeWrite<'a> {
 }
 
 impl EventSource for PipeWrite<'_> {
-    #[allow(clippy::needless_return)]
     fn subscribe(&mut self, co: CoroutineImpl) {
         let s = get_scheduler();
         #[cfg(feature = "io_timeout")]

src/local.rs

@@ -46,8 +46,7 @@ impl CoroutineLocal {
 #[inline]
 pub fn get_co_local_data() -> Option<NonNull<CoroutineLocal>> {
     let ptr = get_local_data();
-    #[allow(clippy::cast_ptr_alignment)]
-    NonNull::new(ptr as *mut CoroutineLocal)
+    NonNull::new(ptr.cast())
 }
 
 #[inline]

src/net/udp.rs

@@ -250,7 +250,6 @@ impl UdpSocket {
         self.sys.set_ttl(ttl)
     }
 
-    #[allow(clippy::trivially_copy_pass_by_ref)]
     pub fn join_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> {
         self.sys.join_multicast_v4(multiaddr, interface)
     }
@@ -259,7 +258,6 @@ impl UdpSocket {
         self.sys.join_multicast_v6(multiaddr, interface)
     }
 
-    #[allow(clippy::trivially_copy_pass_by_ref)]
     pub fn leave_multicast_v4(&self, multiaddr: &Ipv4Addr, interface: &Ipv4Addr) -> io::Result<()> {
         self.sys.leave_multicast_v4(multiaddr, interface)
     }

src/sync/blocking.rs

@@ -13,7 +13,6 @@ pub struct ThreadPark {
     cvar: Condvar,
 }
 
-#[allow(clippy::mutex_atomic)]
 impl ThreadPark {
     pub fn new() -> Self {
         ThreadPark {

src/sync/delay_drop.rs

@@ -20,16 +20,14 @@ impl DelayDrop {
         DropGuard(self)
     }
 
-    #[allow(dead_code)]
-    #[inline]
-    pub fn reset(&self) {
-        // wait the kernel finished
-        while self.can_drop.load(Ordering::Acquire) == 2 {
-            yield_now();
-        }
-
-        self.can_drop.store(0, Ordering::Release);
-    }
+    // #[inline]
+    // pub fn reset(&self) {
+    //     // wait the kernel finished
+    //     while self.can_drop.load(Ordering::Acquire) == 2 {
+    //         yield_now();
+    //     }
+    //     self.can_drop.store(0, Ordering::Release);
+    // }
 }
 
 impl Drop for DropGuard<'_> {

src/sync/mpmc.rs

@@ -294,7 +294,6 @@ impl<T> fmt::Debug for Receiver<T> {
 }
 
 #[cfg(test)]
-#[allow(clippy::redundant_clone)]
 mod tests {
     use super::*;
     use std::env;

src/sync/mpsc.rs

@@ -291,7 +291,6 @@ impl<T> fmt::Debug for Receiver<T> {
 }
 
 #[cfg(test)]
-#[allow(clippy::redundant_clone)]
 mod tests {
     use super::*;
     use std::env;

src/sync/rwlock.rs

@@ -317,7 +317,6 @@ impl<T: ?Sized> Drop for RwLockWriteGuard<'_, T> {
 }
 
 #[cfg(test)]
-#[allow(clippy::redundant_clone)]
 mod tests {
     use crate::sync::mpsc::channel;
     use crate::sync::{Condvar, Mutex, RwLock};

src/sync/spsc.rs

@@ -359,7 +359,6 @@ impl<T> fmt::Debug for Receiver<T> {
 }
 
 #[cfg(test)]
-#[allow(clippy::redundant_clone)]
 mod tests {
     use super::*;
     use std::env;

tests/lib.rs

@@ -216,17 +216,19 @@ fn yield_from_gen() {
 }
 
 #[test]
-#[allow(unused_assignments)]
 fn unpark() {
     let mut a = 0;
+    let mut b = 0;
     coroutine::scope(|scope| {
         let h = go!(scope, || {
             let co = coroutine::current();
             println!("child coroutine name:{co:?}");
             co.unpark();
             a = 5;
+            b += a;
             coroutine::park();
             a = 10;
+            b += a;
             coroutine::park();
         });
 
@@ -239,6 +241,7 @@ fn unpark() {
     });
 
     assert_eq!(a, 10);
+    assert_eq!(b, 15);
 }
 
 #[test]