Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/YAF-54] 공통 컴포넌트를 생성합니다. #13

Merged
merged 4 commits into from
Jan 4, 2025
Merged

[UI/YAF-54] 공통 컴포넌트를 생성합니다. #13

merged 4 commits into from
Jan 4, 2025

Conversation

DongChyeon
Copy link
Member

@DongChyeon DongChyeon commented Jan 4, 2025 •
edited
Loading

Related issue 🛠

closed #10

어떤 변경사항이 있었나요?

  • 🐞 BugFix Something isn't working
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (Junit, etc.)

CheckPoint ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • PR 컨벤션에 맞게 작성했습니다. (필수)
  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕) (필수)
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다. (필수)
  • BugFix의 경우, 버그의 원인을 파악하였습니다. (선택)

Work Description ✏️

  • 공통 컴포넌트 생성
    • radiobutton
    • checkbox
    • switch

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

@DongChyeon DongChyeon added 📱 UI 사용자 인터페이스 관련 작업 💪 동현동현동현동현동현 labels Jan 4, 2025
@DongChyeon DongChyeon requested a review from MoonsuKang January 4, 2025 08:22
@DongChyeon DongChyeon self-assigned this Jan 4, 2025
MoonsuKang
MoonsuKang approved these changes Jan 4, 2025
View reviewed changes
Copy link
Member

@MoonsuKang MoonsuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DongChyeon DongChyeon merged commit 4728731 into develop Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonsuKang MoonsuKang MoonsuKang approved these changes

Assignees

@DongChyeon DongChyeon

Labels
💪 동현동현동현동현동현 📱 UI 사용자 인터페이스 관련 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] 공통 컴포넌트를 개발합니다.
2 participants
@DongChyeon @MoonsuKang