Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/YAF-30] 알람 설정 시 'Time / Hour / Minute' 을 조정하도록 한다 #28

Merged
merged 5 commits into from
Jan 12, 2025

Conversation

DongChyeon
Copy link
Member

Related issue 🛠

closed #20

어떤 변경사항이 있었나요?

  • 🐞 BugFix Something isn't working
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (Junit, etc.)

CheckPoint ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • PR 컨벤션에 맞게 작성했습니다. (필수)
  • merge할 브랜치의 위치를 확인해 주세요(main❌/develop⭕) (필수)
  • Approve된 PR은 assigner가 머지하고, 수정 요청이 온 경우 수정 후 다시 push를 합니다. (필수)
  • BugFix의 경우, 버그의 원인을 파악하였습니다. (선택)

Work Description ✏️

  • 기존 OrbitPicker, OrbitYearMonthPicker의 상태 호이스팅이 가능하도록 하였습니다.
OrbitPicker { amPm, hour, minute ->
    Log.d("OrbitPicker", "amPm: $amPm, hour: $hour, minute: $minute")
}

OrbitYearMonthPicker { lunar, year, month, day ->
    Log.d("OrbitYearMonthPicker", "lunar: $lunar, year: $year, month: $month, day: $day")
}
  • 알람 설정 화면에 OrbitPicker를 추가했습니다.

image

Uncompleted Tasks 😅

N/A

To Reviewers 📢

@DongChyeon DongChyeon added 📱 UI 사용자 인터페이스 관련 작업 💪 동현동현동현동현동현 labels Jan 12, 2025
@DongChyeon DongChyeon self-assigned this Jan 12, 2025
Copy link
Member

@MoonsuKang MoonsuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다

modifier = Modifier.fillMaxWidth(),
) {
Box(modifier = Modifier.fillMaxWidth()) {
// 배경 박스
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3
주석 -

OrbitPicker(
modifier = Modifier.padding(top = 40.dp)
) { amPm, hour, minute ->
Log.d("AlarmAddEditScreen", "amPm: $amPm, hour: $hour, minute: $minute")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3
�나중에 지우기 기억하기

@@ -72,6 +73,7 @@ fun OrbitPickerItem(
if (centerIndex != null) {
val adjustedIndex = centerIndex % items.size
state.selectedItem = items[adjustedIndex]
onValueChange(state.selectedItem)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2
여기에 값 변경 여부를 명시적으로 확인하는 조건을 하나 추가해야될 것 같습니다!
Scroll중 onValueChange가 계속 호출될 수 있을 것 같네요.

val newValue = items[adjustedIndex]
if(state.selectedItem != newValue)

음 예를 들어 이런식으로 할 수 있을 것 같습니다~

Copy link
Member

@MoonsuKang MoonsuKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

@DongChyeon DongChyeon merged commit b588887 into develop Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 동현동현동현동현동현 📱 UI 사용자 인터페이스 관련 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 알람 설정 시 'Time / Hour / Minute' 을 조정하도록 한다
2 participants