-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/YAF-30] 알람 설정 시 'Time / Hour / Minute' 을 조정하도록 한다 #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다
modifier = Modifier.fillMaxWidth(), | ||
) { | ||
Box(modifier = Modifier.fillMaxWidth()) { | ||
// 배경 박스 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
주석 -
OrbitPicker( | ||
modifier = Modifier.padding(top = 40.dp) | ||
) { amPm, hour, minute -> | ||
Log.d("AlarmAddEditScreen", "amPm: $amPm, hour: $hour, minute: $minute") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3
�나중에 지우기 기억하기
@@ -72,6 +73,7 @@ fun OrbitPickerItem( | |||
if (centerIndex != null) { | |||
val adjustedIndex = centerIndex % items.size | |||
state.selectedItem = items[adjustedIndex] | |||
onValueChange(state.selectedItem) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p2
여기에 값 변경 여부를 명시적으로 확인하는 조건을 하나 추가해야될 것 같습니다!
Scroll중 onValueChange가 계속 호출될 수 있을 것 같네요.
val newValue = items[adjustedIndex]
if(state.selectedItem != newValue)
음 예를 들어 이런식으로 할 수 있을 것 같습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOOD
Related issue 🛠
closed #20
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
N/A
To Reviewers 📢