[UI/YAF-000] 온보딩 Lottie Animation을 적용합니다. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
reviewed
Jan 16, 2025
There was a problem hiding this comment.
[p4]
온보딩 외에도 사용할 일이 있어서 core:ui 의 component에 배도 좋을 거 같아요
There was a problem hiding this comment.
[p5]
LottieAnimation의 크기를 직접적으로 fillMaxWidth()로 조절하는 방법이 없는 거 같긴 한데... 없다면 무시하셔도 됩니다.
Comment on lines
50
to
61
| scaleX = when (contentScale) { | ||
| ContentScale.Fit -> scaleXAdjustment | ||
| ContentScale.FillWidth -> 1.2f * scaleXAdjustment | ||
| ContentScale.FillHeight -> 1.5f * scaleXAdjustment | ||
| else -> scaleXAdjustment | ||
| }, | ||
| scaleY = when (contentScale) { | ||
| ContentScale.Fit -> scaleYAdjustment | ||
| ContentScale.FillWidth -> 1.2f * scaleYAdjustment | ||
| ContentScale.FillHeight -> 1.5f * scaleYAdjustment | ||
| else -> scaleYAdjustment | ||
| }, |
There was a problem hiding this comment.
[p4]
Suggested change
| scaleX = when (contentScale) { | |
| ContentScale.Fit -> scaleXAdjustment | |
| ContentScale.FillWidth -> 1.2f * scaleXAdjustment | |
| ContentScale.FillHeight -> 1.5f * scaleXAdjustment | |
| else -> scaleXAdjustment | |
| }, | |
| scaleY = when (contentScale) { | |
| ContentScale.Fit -> scaleYAdjustment | |
| ContentScale.FillWidth -> 1.2f * scaleYAdjustment | |
| ContentScale.FillHeight -> 1.5f * scaleYAdjustment | |
| else -> scaleYAdjustment | |
| }, | |
| scaleX = getScaleFromContentScale(contentScale) * scaleXAdjustment, | |
| scaleY = getScaleFromContentScale(contentScale) * scaleYAdjustment, |
scale 비율을 계산하는 헬퍼 함수를 작성하는 것도 좋을 거 같아요
| ) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
[p4]
Suggested change
| } | |
| } | |
| private fun getScaleFromContentScale(contentScale: ContentScale): Float { | |
| return when (contentScale) { | |
| ContentScale.Fit -> 1f | |
| ContentScale.FillWidth -> 1.2f | |
| ContentScale.FillHeight -> 1.5f | |
| else -> 1f | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #39
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
testmama.mp4
test1231231.mp4
Uncompleted Tasks 😅
To Reviewers 📢