[REFACTOR/YAF-000] 온보딩 UI 개선을 진행합니다. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongChyeon
reviewed
Jan 19, 2025
| ) | ||
| OrbitPickerItem( | ||
| state = yearPickerState, | ||
| items = yearItems, | ||
| visibleItemsCount = 5, | ||
| itemSpacing = itemSpacing, | ||
| textStyle = OrbitTheme.typography.title2SemiBold, | ||
| modifier = Modifier.width(screenWidth * 0.25f), | ||
| modifier = Modifier.width(screenWidth * 0.28f), | ||
| textModifier = Modifier.padding(8.dp), | ||
| infiniteScroll = true, |
There was a problem hiding this comment.
[p3]
ios 온보딩 영상을 보니 년을 고를 떄는 무한 스크롤이 아닌 거 같아요
DongChyeon
reviewed
Jan 19, 2025
There was a problem hiding this comment.
[p5]
오옹 Job 객체 사용하는 것보다 MutableSharedFlow 사용하는 방식이 더 깔끔하네요
DongChyeon
reviewed
Jan 19, 2025
| onTermsClick = { /* Handle terms click */ }, | ||
| onPrivacyPolicyClick = { /* Handle privacy policy click */ }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
[p3]
Suggested change
| } | |
| } | |
| Spacer(modifier = Modifier.height(12.dp)) |
하단에 여백 추가해야 해요!
DongChyeon
reviewed
Jan 19, 2025
| else -> false | ||
| } | ||
| }, | ||
| .clickable { isChecked = !isChecked }, |
There was a problem hiding this comment.
[p2]
체크되어 있으면 다음 버튼 활성화해야 할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #43
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢