-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI/YAF-82] 미션 메인 UI를 구현합니다. #52
Conversation
어제 저희 능지 이슈가 있었습니다...! @Composable
fun OnboardingScreen(
currentStep: Int,
totalSteps: Int,
isButtonEnabled: Boolean,
onNextClick: () -> Unit,
onBackClick: (() -> Unit)?,
buttonLabel: String,
showTopAppBar: Boolean = true,
showTopAppBarActions: Boolean = true,
content: @Composable () -> Unit,
) {
Column(
modifier = Modifier
.fillMaxSize()
.background(OrbitTheme.colors.gray_900)
.statusBarsPadding()
.navigationBarsPadding()
.imePadding(),
) {
// ...
}
} 온보딩 화면을 보면은 enableToEdge()를 통해서 FullScreen으로 만들어놓고, 다시 무마를 하고 있던 거였지요!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[p3]
Pixel 폰이 아닌 갤럭시일 경우, navigationBarsPadding() 추가 필요합니다.
Scaffold(
modifier = modifier.fillMaxSize(),
bottomBar = {
OrbitBottomNavigationBar(
visible = false,
currentTab = navigator.currentTab,
entries = TopLevelDestination.entries.toImmutableList(),
onClickItem = navigator::navigateToTopLevelDestination,
)
},
contentColor = OrbitTheme.colors.gray_900,
) {
NavHost(
navController = navigator.navController,
startDestination = navigator.startDestination,
modifier = Modifier
.fillMaxSize()
.navigationBarsPadding(),
) {
// ...
}
}
}
navigationBarsPadding -> 디자인 상으로 시스템바 까지 screen 영역을 가지고 있어서 넣지 않았는데 혹시 그러면 screen단에서 전체화면의 비율로 bottom의 spacer를 처리했는데 이것도 수정을 할까요? |
넵넵!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다
Related issue 🛠
closed #51
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
새벽 2시까지 짱구를 굴린 enableEdgeToEdge 구조를 일단 올렸습니다.
SystemUiController 이제 deprecated 됨