[UI/YAF-85] 알람 메인 화면 배경을 구현합니다. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonsuKang
requested changes
Jan 22, 2025
There was a problem hiding this comment.
p2
이거 이미 있습니다.
ScreenPercentage.kt
There was a problem hiding this comment.
예전에 작업한 거 다시 리베이스 해서 한거라 최종본에는 없습니당
|
|
||
| @Composable | ||
| fun HomeScreen() { | ||
| val systemUiController = rememberSystemUiController() |
There was a problem hiding this comment.
예전에 작업한 거 다시 리베이스 해서 한거라 최종본에는 없습니당
gradle/libs.versions.toml
Outdated
| @@ -68,6 +67,7 @@ process-pheonix = "3.0.0" | |||
| lottie = "6.1.0" | |||
| accompanist = "0.37.0" | |||
|
|
|||
| accompanist = "0.28.0" | |||
There was a problem hiding this comment.
accompanist-systemui 쓰려고 했던건데 예전에 작업한 거 다시 리베이스 해서 한거라 최종본에는 없습니당
gradle/libs.versions.toml
Outdated
| @@ -111,6 +111,7 @@ compose-ui-test-manifest = { group = "androidx.compose.ui", name = "ui-test-mani | |||
| compose-ui-test-junit4 = { group = "androidx.compose.ui", name = "ui-test-junit4" } | |||
| compose-ui-foundation = { group = "androidx.compose.foundation", name = "foundation" } | |||
| compose-compiler-extension = { module = "org.jetbrains.kotlin:compose-compiler-gradle-plugin", version.ref = "kotlin" } | |||
| accompanist-systemui = { group = "com.google.accompanist", name = "accompanist-systemuicontroller", version.ref = "accompanist" } | |||
There was a problem hiding this comment.
예전에 작업한 거 다시 리베이스 해서 한거라 최종본에는 없습니당
Comment on lines
+49
to
+55
| onDismissRequest = { | ||
| if (cancelText == null) { | ||
| onConfirm() | ||
| } else { | ||
| onCancel?.invoke() | ||
| } | ||
| }, |
There was a problem hiding this comment.
p3
취소랑 확인을 onDismissRequest 하나로 취합하고 있는 구조 인가요?
There was a problem hiding this comment.
확인만 있는 Dialog의 경우 다른 영역을 눌러서 onDismissRequest 를 호출할 때 onCofirm()을 호출하는 구조며
확인/취소가 있는 Dialog라면 다른 영역을 눌렀을 때 onCancel()을 호출하는 구조입니다.
부자연스러운 흐름인 것 같다면 말씀해주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
closed #15
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢