-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TNT-124] 디자인 시스템 관련 코드 작성 #16
Open
FpRaArNkK
wants to merge
14
commits into
develop
Choose a base branch
from
TNT-124-designSystemResources
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 What is the PR?
🚨원활한 PR 리뷰를 위해 PR을 분리하여 작성했습니다🚨
🪄 Changes
🌐 Common Changes
Notion/iOS/트러블 슈팅에 내용을 기록해놓았습니다
.swiftlint.yml
파일의 규칙을 준수합니다.🔥 PR Point
Color는 Gray / Color 스케일로 나누어 디자인 시스템과 매칭할 수 있도록 작성했습니다.
추후에 추가될 Sementic Color는 struct를 하나씩 추가하며 구현하면 될 것 같습니다.
사용할때는 기존 SwiftUI Color를 사용하는 것 처럼 사용하시면 됩니다.
Font는 Typography 구조체 내부에서 구현되었습니다
Pretendard 폰트 구조체, 디자인 시스템 구현을 위한 FontStyle 구조체도 이곳에 포함됩니다.
최종적으로 extension Typography.FontStyle에서 디자인 시스템 구현 코드가 작성됩니다.
SwiftUI의 ViewModifier를 추가하여
사용할때는 바로
.typographyStyle(_:)
를 추가하면 됩니다.TextField, TextEditor와 같은 UI엔 별도 지정이 필요하여, 아래와 같이 사용하시면 됩니다!
Icon/Image는 ImageResource 타입으로 extension 구현되었습니다.
사용할때는 기존 SwiftUI에서 Image에 resource 입력하는 함수를 똑같이 사용하시면 됩니다.
🙆🏻 To Reviewers
각 인터페이스별 디테일한 사용 방법, 설명은 Notion/iOS/앱 개발 분석 문서 에 정리해놓았습니다!
💭 Related Issues