generated from yuminn-k/yuminnk-nextjs-template
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ログインページの最適化 #129
Merged
Merged
ログインページの最適化 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix an error where client-side execution was inconsistent with server-side rendering. - Login component image not sized correctly, fix the CSS Related issue: YJU-OKURA#128
Updated the images.remotePatterns configuration in next.config.js to use the new format with hostname and pathPattern properties. Related issue: YJU-OKURA#128
Reordered the import statements for better readability and consistency. Related issue: YJU-OKURA#58
👍 |
Lainari
approved these changes
Apr 30, 2024
dorimu0
added a commit
to dorimu0/project_minori-next-deployment-repo
that referenced
this pull request
Oct 23, 2024
- Modified the Google Login page to use URLSearchParams for obtaining the 'code' parameter from the URL. - Implemented `getServerSideProps` to disable static generation, ensuring the page renders on the client side. - Added error handling for login response to improve user state management and cookie handling. Related issue: YJU-OKURA#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 このPRで解決したい問題は何ですか?
✨ このPRで主に変わったことは何ですか?
🔖 主な変更点以外に追加で変更された部分はありますか?
🙏🏻 Reviewerに特に見ていただきたい部分はありますか?
🩺 このPRでテストや検証が必要な部分はありますか?
📚 関連するIssueやTrello、ドキュメント
🖥 作動する様子
📌 PRを行う際の注意点