Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wl_compositor@v6 #55

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

kchibisov
Copy link
Contributor

No description provided.

src/niri.rs Show resolved Hide resolved
src/niri.rs Show resolved Hide resolved
src/niri.rs Outdated Show resolved Hide resolved
@kchibisov kchibisov force-pushed the compositor-v6 branch 2 times, most recently from 37692b2 to dab97f6 Compare October 26, 2023 20:37
@kchibisov
Copy link
Contributor Author

What should we do with subsurfaces and other surfaces not having configure events? For cursor and its related surface we're using the output refresh stuff. I'd guess that for subsurfaces we should just handle them from the commit hook?

@YaLTeR
Copy link
Owner

YaLTeR commented Oct 27, 2023

What should we do with subsurfaces and other surfaces not having configure events?

You mean like, window appears and gets its preferred scale, then it creates a subsurface which doesn't until the window moves to another output? Yeah, I'm not sure. We could send them from Layout::refresh() which is called in loop callback and already handles states like activated I guess.

@kchibisov
Copy link
Contributor Author

I think it should work now.

@kchibisov kchibisov requested a review from YaLTeR October 27, 2023 14:28
@kchibisov kchibisov marked this pull request as ready for review October 27, 2023 14:28
src/handlers/mod.rs Show resolved Hide resolved
src/niri.rs Show resolved Hide resolved
src/niri.rs Show resolved Hide resolved
src/niri.rs Show resolved Hide resolved
@kchibisov kchibisov requested a review from YaLTeR October 29, 2023 08:52
@YaLTeR YaLTeR merged commit 0a20529 into YaLTeR:main Oct 29, 2023
4 checks passed
@YaLTeR
Copy link
Owner

YaLTeR commented Oct 29, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants