Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split-csv-timeine correlation result #222

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Jan 18, 2025

What Changed

Test

Integration-Test

https://github.com/Yamato-Security/takajo/actions/runs/12844375962
(Integration-Test in the Linux environment is broken from before this PR and will be fixed)

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket added the bug Something isn't working label Jan 18, 2025
@fukusuket fukusuket added this to the v2.8.0 milestone Jan 18, 2025
@fukusuket fukusuket self-assigned this Jan 18, 2025
@fukusuket
Copy link
Collaborator Author

before fix

% ./takajo-2.8.0-mac-aarch64 split-csv-timeline -t ../hayabusa-3.0.1-mac-aarch64/out.csv -q
Started the Split CSV Timeline command

This command will split a large CSV timeline into many multiple ones based on computer name.
If you want to separate the field data by newlines, add the -m option.

File: ../hayabusa-3.0.1-mac-aarch64/out.csv (8.42 KB)
Splitting the Hayabusa CSV timeline. Please wait.


100%|█████████████████████████| 63/63 [ 0.0s< 0.0s, 166.61k/sec]

Saved file: output/PC01.example.corp-HayabusaResults.csv (404 Bytes)
Saved file: output/PC04.example.corp-HayabusaResults.csv (252 Bytes)
Saved file: output/IEWIN7-HayabusaResults.csv (2.15 KB)
Saved file: output/DC1.insecurebank.local-HayabusaResults.csv (256 Bytes)
Saved file: output/MSEDGEWIN10-HayabusaResults.csv (3.06 KB)
Saved file: output/LAPTOP-JU4M3I0E ¦ MSEDGEWIN10 ¦ win10.ecorp.com-HayabusaResults.csv (284 Bytes)
Saved file: output/01566s-win16-ir.threebeesco.com-HayabusaResults.csv (265 Bytes)
Saved file: output/LAPTOP-JU4M3I0E-HayabusaResults.csv (397 Bytes)
Saved file: output/DESKTOP-NTSSLJD ¦ MSEDGEWIN10-HayabusaResults.csv (264 Bytes)
Saved file: output/02694w-win10.threebeesco.com ¦ LAPTOP-JU4M3I0E-HayabusaResults.csv (281 Bytes)
Saved file: output/FS03.offsec.lan ¦ LAPTOP-JU4M3I0E-HayabusaResults.csv (268 Bytes)
Saved file: output/dc1.test.local-HayabusaResults.csv (249 Bytes)
Saved file: output/IE8Win7-HayabusaResults.csv (321 Bytes)
Saved file: output/IE10Win7 ¦ IE8Win7 ¦ IE9Win7-HayabusaResults.csv (236 Bytes)
Saved file: output/IE10Win7-HayabusaResults.csv (863 Bytes)
Saved file: output/37L4247D28-05 ¦ IE8Win7-HayabusaResults.csv (226 Bytes)
Saved file: output/IE8Win7 ¦ IE9Win7-HayabusaResults.csv (220 Bytes)
Saved file: output/IE10Win7 ¦ IE9Win7-HayabusaResults.csv (220 Bytes)


Elapsed time: 0 hours, 0 minutes, 0 seconds

after fix

% ./takajo split-csv-timeline -t ../hayabusa-3.0.1-mac-aarch64/out.csv -q
Started the Split CSV Timeline command

This command will split a large CSV timeline into many multiple ones based on computer name.
If you want to separate the field data by newlines, add the -m option.

File: ../hayabusa-3.0.1-mac-aarch64/out.csv (8.42 KB)
Splitting the Hayabusa CSV timeline. Please wait.


100%|█████████████████████████| 63/63 [ 0.0s< 0.0s, 322.52k/sec]

Saved file: output/PC01.example.corp-HayabusaResults.csv (404 Bytes)
Saved file: output/PC04.example.corp-HayabusaResults.csv (252 Bytes)
Saved file: output/IEWIN7-HayabusaResults.csv (2.15 KB)
Saved file: output/DC1.insecurebank.local-HayabusaResults.csv (256 Bytes)
Saved file: output/MSEDGEWIN10-HayabusaResults.csv (3.40 KB)
Saved file: output/LAPTOP-JU4M3I0E-HayabusaResults.csv (927 Bytes)
Saved file: output/win10.ecorp.com-HayabusaResults.csv (284 Bytes)
Saved file: output/01566s-win16-ir.threebeesco.com-HayabusaResults.csv (265 Bytes)
Saved file: output/DESKTOP-NTSSLJD-HayabusaResults.csv (264 Bytes)
Saved file: output/02694w-win10.threebeesco.com-HayabusaResults.csv (281 Bytes)
Saved file: output/FS03.offsec.lan-HayabusaResults.csv (268 Bytes)
Saved file: output/dc1.test.local-HayabusaResults.csv (249 Bytes)
Saved file: output/IE8Win7-HayabusaResults.csv (700 Bytes)
Saved file: output/IE10Win7-HayabusaResults.csv (1.09 KB)
Saved file: output/IE9Win7-HayabusaResults.csv (474 Bytes)
Saved file: output/37L4247D28-05-HayabusaResults.csv (226 Bytes)


Elapsed time: 0 hours, 0 minutes, 0 seconds

@fukusuket fukusuket marked this pull request as ready for review January 18, 2025 13:21
@fukusuket fukusuket marked this pull request as draft January 18, 2025 13:30
@fukusuket fukusuket marked this pull request as ready for review January 18, 2025 23:12
@fukusuket
Copy link
Collaborator Author

I fixed integration-test!
https://github.com/Yamato-Security/takajo/actions/runs/12848447457/job/35825783282
Closed #223

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit fbf127a into main Jan 19, 2025
2 checks passed
@YamatoSecurity YamatoSecurity deleted the 211-fix-split-csv-timeline branch January 19, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: split-csv-timeine command creates separate timelines for correlation results
2 participants