Skip to content

Commit

Permalink
Remove unnecessary mocks
Browse files Browse the repository at this point in the history
This is what I get for trusting GHA rather than also running the tests
internally :)

These mocks are no longer required and are actually causing test
failures internally.
  • Loading branch information
nemacysts committed Feb 1, 2024
1 parent 91e175e commit d6ee4ce
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/utils/scribereader_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def test_read_log_stream_for_action_run_min_date_and_max_date_today():
"tron.utils.scribereader.get_scribereader_host_and_port",
autospec=True,
return_value=("host", 1234),
), mock.patch("tron.utils.scribereader.scribereader", autospec=True,), mock.patch(
), mock.patch(
"tron.utils.scribereader.scribereader.get_stream_reader",
autospec=True,
) as mock_stream_reader, mock.patch(
Expand Down Expand Up @@ -97,7 +97,7 @@ def test_read_log_stream_for_action_run_min_date_and_max_date_different_days():
"tron.utils.scribereader.get_scribereader_host_and_port",
autospec=True,
return_value=("host", 1234),
), mock.patch("tron.utils.scribereader.scribereader", autospec=True,), mock.patch(
), mock.patch(
"tron.utils.scribereader.scribereader.get_stream_reader",
autospec=True,
) as mock_stream_reader, mock.patch(
Expand Down Expand Up @@ -195,7 +195,7 @@ def test_read_log_stream_for_action_run_min_date_and_max_date_in_past():
"tron.utils.scribereader.get_scribereader_host_and_port",
autospec=True,
return_value=("host", 1234),
), mock.patch("tron.utils.scribereader.scribereader", autospec=True,), mock.patch(
), mock.patch(
"tron.utils.scribereader.scribereader.get_stream_reader",
autospec=True,
) as mock_stream_reader, mock.patch(
Expand Down Expand Up @@ -261,7 +261,7 @@ def test_read_log_stream_for_action_run_min_date_and_max_date_for_long_output():
"tron.utils.scribereader.get_scribereader_host_and_port",
autospec=True,
return_value=("host", 1234),
), mock.patch("tron.utils.scribereader.scribereader", autospec=True,), mock.patch(
), mock.patch(
"tron.utils.scribereader.scribereader.get_stream_reader",
autospec=True,
) as mock_stream_reader, mock.patch(
Expand Down

0 comments on commit d6ee4ce

Please sign in to comment.