Check to see if we error on any events in handle_event function - TRON-2051 #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
reviewed
Dec 4, 2023
| if clog is None: | ||
| log.debug("Clog logger unavailable. Unable to log event") | ||
| else: | ||
| clog.log_line("tmp_missed_tronevents", json.dumps(event)) # Capture event |
|
@EmanElsaban did we end up including these changes in the python upgrade branch? (i.e., can we close this PR?) |
|
(we figured out that the issue we'd been looking for was really a bad interaction between the k8s client lib and python loggers - every model added a new logger and every setLevel call operated on all the loggers that had been created, which slowed down over time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a try/except block to check to see if we error on any event in handle_event function. Erroring on any event means we don't handle this event at all and thus we don't update Tron's state machine for it