TRON-2035: Fix public docs w/ new RTDv2 config #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to Yelp/paasta#3745 , we need to add the new RTD v2 config file.
They thankfully still support py3.6 on focal, and the build seems to work as expected on a personal fork + rtd project:
https://test-jfong-tron.readthedocs.io/en/latest/man_tronctl.html
https://readthedocs.org/projects/test-jfong-tron/builds/22836317/
Latest passing build of our public docs seems to have run nearly the exact same set of commands (although curiously ran on py3.7 instead of 3.6! I think it's fine to stick w/ 36 to match the service repo + bump to 3.8 when we do everything tho):
https://readthedocs.org/projects/tron/builds/19664551/