Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify stdout or stderr in the scribereader command #943

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

edingroot
Copy link
Contributor

@edingroot edingroot commented Feb 23, 2024

To filter stdout/stderr logs in the scribereader command, which users are adviced to run.

image

=> change to

scribereader -e pnw stream_paasta_app_output_spark_spark_driver_test_redshift__test_redshift --min-date 2024-02-23 | jq --raw-output 'select(.tron_run_number==0 and .component=="stdout") | .message'

Copy link

@88manpreet 88manpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections on my end. Would wait for luisp's review.

Interesting. I like this change being more accurate and expected behavior technically.
Behaviorally, I wonder if users reading the logs would have preferred to just run one command to get all the logs and then filter as necessary.

++ for this change.

@edingroot edingroot merged commit 0671979 into master Feb 28, 2024
3 checks passed
@edingroot edingroot deleted the u/chi/select_log_component branch February 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants