Adding prometheus endpoint in tron - TRON-2124 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanElsaban
force-pushed
the
u/emanelsabban/TRON-2124-expose-prom-metrics
branch
from
3e23199
to
6fb14d9
Compare
jvperrin
approved these changes
Mar 5, 2024
KaspariK
approved these changes
Mar 5, 2024
bobokun
approved these changes
Mar 5, 2024
nemacysts
reviewed
Mar 16, 2024
| @@ -10,6 +10,7 @@ ipython | |||
| Jinja2>=3.1.2 | |||
| lockfile | |||
| moto | |||
| prometheus-client==0.20.0 | |||
There was a problem hiding this comment.
we should remove this pin from requirement-minimal - leaving it in here means "any version that is not 0.20.0 will not work"
i.e., this line should just have the dependency name
|
|
||
| tron_cpu_gauge = Gauge("tron_k8s_cpus", "Measuring CPU for tron jobs on K8s") | ||
| tron_memory_gauge = Gauge("tron_k8s_mem", "Measuring memory for tron jobs on K8s") | ||
| tron_disk_gauge = Gauge("tron_k8s_disk", "Measuring disk for tron jobs on K8s") |
There was a problem hiding this comment.
suggestion (feel free to ignore):
tron_cpu_gauge = Gauge("tron_k8s_cpus", "Total number of CPUs allocated to Tron-launched containers")
tron_memory_gauge = Gauge("tron_k8s_mem", "Total amount of memory allocated to Tron-launched containers (in megabytes)")
tron_disk_gauge = Gauge("tron_k8s_disk", "Total amount of disk allocated to Tron-launched containers (in megabytes)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds prometheus endpoint at the path /api/prom-metrics and adds gauges for some of the metrics to test it out.