Update task_proc to better handle killing tasks #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen that task_proc/k8s will sometimes not correctly send events for pods that we try to kill ourselves (either because the pods are already gone or because the event is somehow missing data), so this task_proc version will send synthetic events when we call kill() to ensure that tron is in the correct state :)
|
This requires Yelp/task_processing#214 EDIT: task_proc change is now merged, so this now builds :) |
jfongatyelp
reviewed
May 8, 2024
Co-authored-by: Jen Patague <[email protected]>
|
(retested after the last change: still looks good :)) |
jfongatyelp
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen that task_proc/k8s will sometimes not correctly send events for pods that we try to kill ourselves (either because the pods are already gone or because the event is somehow missing data), so this task_proc version will send synthetic events when we call kill() to ensure that tron is in the correct state :)