Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing scribereader tests #983

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix failing scribereader tests #983

merged 1 commit into from
Jun 28, 2024

Conversation

yaroliakh
Copy link
Contributor

Fixing scribereader tests for previous change: #979

@yaroliakh yaroliakh changed the title Update scribereader tests Fix failing scribereader tests Jun 27, 2024
@yaroliakh yaroliakh merged commit 5cc97b5 into master Jun 28, 2024
4 checks passed
cuza added a commit that referenced this pull request Jul 8, 2024
@cuza
Merge remote-tracking branch 'origin/master' into u/cuza/disable_retr…
e6d6818 
…ies_on_lost

* origin/master:
  Released 2.2.6 via make release
  Update scribereader tests (#983)
  Released 2.2.5 via make release
  Update yelp_clog and use datetime range for S3 logs (#979)
  Add clarification around reverting changes that touch DynamoDB data (#982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvperrin jvperrin jvperrin approved these changes

@nemacysts nemacysts Awaiting requested review from nemacysts

@jfongatyelp jfongatyelp Awaiting requested review from jfongatyelp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaroliakh @jvperrin