Gcp key detector #663
Open
Gcp key detector #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Please merge master to your branch to re-run CI. |
|
I have seen this PR stale for over a year - can we try it again? Thanks. @LucasAndradeDias @jpdakran |
|
@chrislin22 if you need these changes, feel free to open a PR yourself with what's in here so we can review and merge that instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This changes adds to detect-secrets a new plugin to find Google Cloud API keys and oauth2 client ids.
What is the current behavior?
When detect secrets finds a GCP API key in code, it shows the key as 64base key and as GCP Keys.
With oauth2 cgp client-id the detect-secrets does not find it as secrets.
What is the new behavior (if this is a feature change)?
With the currently changes, the detect secrets is now able to correctly show infos about GCP Keys.
Does this PR introduce a breaking change?
No changes are need.
Other information:
Hi, I'am Lucas and I working on a team where we are interested on using Detect-secrets in our CI pipeline. Although this projects is already completed and it has much plugins, we miss some of detections like GCP, Firebase and Facebook tokens plugins. And that's the reason I'am making this pull request, to help detect-secrets to help us and the community in general.