Calculate line number correctly in multi-line strings #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Please merge master to your branch to re-run CI. |
jpdakran
reviewed
Mar 30, 2023
| line=line, | ||
| context=code_snippet, | ||
| ): | ||
| if determine_file_type(filename) == FileType.YAML and secret.secret_value: |
There was a problem hiding this comment.
Have you looked at yaml transformer? Yaml files are transformed according to this transformer. So any changes should be done here.
There was a problem hiding this comment.
Hi @jpdakran !
Yes I have, it seems it merges the lines into 1 which makes sense from scanning perspective, but not from finding perspective. Otherwise, the secret's line is the first one, even though the secret is on the third line.
The yaml transformer doesn't retain a mapping of this...
|
hi @nimrodkor 😄 could you please merge master into your branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix for a case where a multi-line yaml string has secrets in a line which is not the very first one.
Today, the error is pointed at the beginning of the string, even if the secret itself is in some row down the file.
What is the new behavior (if this is a feature change)?
It will point to the actual line with the secret in it
Does this PR introduce a breaking change?
No
Other information:
Already working on our (bridgecrewio) fork :)