Check netloc in urlparse result if path is empty #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-weiss-programmer thank you for your contribution! Could you advice me on which version have one or the other behaviour? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where certain versions of urllib will put the results of a parsed file (e.g. file://testing/custom_filters.py::is_invalid_secret) into the netloc property of urlparse instead of the path property.
#715
What is the new behavior (if this is a feature change)?
The custom filter parser will now check netloc if path is not populated
Does this PR introduce a breaking change?
Users should have to make no changes, as it prefers path over netloc