Add big-bounce test for non-default configs (#3975)

This test should grow over time to include other commonly used
options/configs: e.g., the various types of secrets and whatnot

tests/test_kubernetes_tools.py

@@ -4242,7 +4242,7 @@ def test_load_custom_resources():
     ]
 
 
-def test_warning_big_bounce():
+def test_warning_big_bounce_default_config():
     job_config = kubernetes_tools.KubernetesDeploymentConfig(
         service="service",
         instance="instance",
@@ -4332,6 +4332,53 @@ def test_warning_big_bounce_routable_pod():
         ), "If this fails, just change the constant in this test, but be aware that deploying this change will cause every smartstack-registered service to bounce!"
 
 
+def test_warning_big_bounce_common_config():
+    job_config = kubernetes_tools.KubernetesDeploymentConfig(
+        service="service",
+        instance="instance",
+        cluster="cluster",
+        config_dict={
+            # XXX: this should include other common options that are used
+            "cap_add": ["SET_GID"],
+        },
+        branch_dict={
+            "docker_image": "abcdef",
+            "git_sha": "deadbeef",
+            "image_version": None,
+            "force_bounce": None,
+            "desired_state": "start",
+        },
+    )
+
+    with mock.patch(
+        "paasta_tools.utils.load_system_paasta_config",
+        return_value=SystemPaastaConfig(
+            {
+                "volumes": [],
+                "hacheck_sidecar_volumes": [],
+                "expected_slave_attributes": [{"region": "blah"}],
+                "docker_registry": "docker-registry.local",
+            },
+            "/fake/dir/",
+        ),
+        autospec=True,
+    ) as mock_load_system_paasta_config, mock.patch(
+        "paasta_tools.kubernetes_tools.load_system_paasta_config",
+        new=mock_load_system_paasta_config,
+        autospec=False,
+    ), mock.patch(
+        "paasta_tools.kubernetes_tools.load_service_namespace_config",
+        return_value=ServiceNamespaceConfig(),
+        autospec=True,
+    ):
+        assert (
+            job_config.format_kubernetes_app().spec.template.metadata.labels[
+                "paasta.yelp.com/config_sha"
+            ]
+            == "configb24f9dd2"
+        ), "If this fails, just change the constant in this test, but be aware that deploying this change will cause every service to bounce!"
+
+
 @pytest.mark.parametrize(
     "pod_node_name,node,expected",
     [