Skip to content

Commit

Permalink
Allowlist eks files in config_utils (#3984)
Browse files Browse the repository at this point in the history
updater.write_configs() is not just used for managing autotune files - SSR shard creation uses it to manage creating/updating the non-autotuned_defaults config files (which are now always eks-CLUSTER.yaml).
  • Loading branch information
kedarv authored Oct 29, 2024
1 parent 334e743 commit 5d78470
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions paasta_tools/config_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"deploy",
"smartstack",
"cassandracluster",
"eks",
)

# this could use a better name - but basically, this is for pairs of instance types
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def test_auto_config_updater_validate(mock_validate_file, all_valid, updater):
mock_validate_file.side_effect = [True, all_valid, True]

updater.write_configs("foo", "kubernetes-norcal-devc", {"a": 2})
updater.write_configs("foo", "kubernetes-pnw-devc", {"a": 2})
updater.write_configs("foo", "eks-pnw-devc", {"a": 2})
assert updater.validate() == all_valid
assert mock_validate_file.call_count == 2

Expand Down

0 comments on commit 5d78470

Please sign in to comment.