Skip to content

Commit

Permalink
Update regular filename reference in autotune files (#3961)
Browse files Browse the repository at this point in the history
We've generally decided that we'll be leaving files as eks-*.yaml - and
while there's some additional steps that need to be taken, those will
need to happen once we've gotten rid of all of the kubernetes-*.yaml
files.

As we still have some unmigrated operators, that means we still need to
wait. However, we can go ahead and update the comment in the autotune
files since those have recently caused some confusion (and assume that
anyone looking at autotune files is looking at them for non-operator
services)
  • Loading branch information
nemacysts authored Sep 17, 2024
1 parent a0e932b commit 966e1d8
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion paasta_tools/config_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,14 @@ def write_auto_config_data(
if comment:
content = (
yaml.round_trip_load(
comment.format(regular_filename=f"{service}/{extra_info}.yaml")
comment.format(
# this is a bit of a hack, but we've decided to not rename files back to kubernetes-*
# files. while we still need to update things to reference the eks files directly, there's
# still a couple of places where we still need kubernetes-* files (e.g., unmigrated operators)
# so for now let's just assume that autotuned things will always actually have their human-managed
# config in eks-* files
regular_filename=f"{service}/{extra_info.replace('kubernetes-', 'eks-')}.yaml",
)
)
if comment
else {}
Expand Down

0 comments on commit 966e1d8

Please sign in to comment.