Handle AttributeError exceptions in logs CLI (#3980)

* Handle AttributeError exceptions in logs CLI
Yelp · Oct 16, 2024 · 979ea52 · 979ea52
1 parent 762ebc8
commit 979ea52
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/paasta_tools/cli/cmds/logs.py b/paasta_tools/cli/cmds/logs.py
@@ -329,6 +329,12 @@ def paasta_app_output_passes_filter(
     # https://github.com/gweis/isodate/issues/53
     except ValueError:
         return True
+    except AttributeError:
+        # Timestamp might be missing. We had an issue where OTel was splitting overly long log lines
+        # and not including timestamps in the resulting log records (OBSPLAT-2216).
+        # Although this was then fixed in OTel, we should not rely on timestamps being present,
+        # as the format cannot be guaranteed.
+        return False
     if not check_timestamp_in_range(timestamp, start_time, end_time):
         return False
     return (