Merge pull request #3955 from Yelp/u/ahaswell/perel-4256-additional-e…

…ndpoint-schema additional endpoint schema
Yelp · Sep 11, 2024 · e4b077d · e4b077d
2 parents bd7c9b9 + 344ac7f
commit e4b077d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/docs/source/yelpsoa_configs.rst b/docs/source/yelpsoa_configs.rst
@@ -1088,7 +1088,6 @@ These keys provide optional overrides for the default alerting behaviour.
           page_nonprod: true
           error_threshold_ratio: 0.02
           minimum_error_rps: 10
-          namespace_alert: false
           endpoints:
             - name: GET /something
             - name: GET /something/else
@@ -1110,8 +1109,6 @@ These keys provide optional overrides for the default alerting behaviour.
      environments. Defaults to **false**.
    - ``error_threshold_ratio``: Error threshold ratio (0-1). Defaults to **0.01**.
    - ``minimum_error_rps``: Minimum error rate per second, minimum is zero. Defaults to **5**.
-   - ``namespace_alert``: Toggle namespace alerting. Defaults to **true**. Can be used to disable alerting for the
-     namespace when alerts are configured for specific endpoints.
    - ``endpoints``: List of endpoints to create alerts for.
       - ``name``: The name of the endpoint.
       - ``error_threshold_ratio``: Error threshold ratio (0-1). If not specified the threshold will be inherited from the parent.

diff --git a/paasta_tools/cli/schemas/smartstack_schema.json b/paasta_tools/cli/schemas/smartstack_schema.json
@@ -258,9 +258,6 @@
                         "type": "integer",
                         "minimum": 0
                     },
-                    "namespace_alert": {
-                        "type": "boolean"
-                    },
                     "endpoints": {
                         "type": "array",
                         "items": {
@@ -273,6 +270,24 @@
                                     "type": "number",
                                     "minimum": 0,
                                     "maximum": 1
+                                },
+                                "team": {
+                                    "type": "string"
+                                },
+                                "slack_channel": {
+                                    "type": "string"
+                                },
+                                "project": {
+                                    "type": "string"
+                                },
+                                "ticket": {
+                                    "type": "boolean"
+                                },
+                                "page": {
+                                    "type": "boolean"
+                                },
+                                "page_nonprod": {
+                                    "type": "boolean"
                                 }
                             },
                             "required": [