Introduced new soa key for rotating database passwords #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- database_credentials is a top level key. The next key will be a datastore. This could be MySQL or Cassandra or anything else.
Each data store (dstore) contains a name, eg {mysql: ['cred1', 'cred2']}.
These credentials point to a vault path under /dstore/mysql/{cred1,cred2}
These passwords are then mapped to the paasta service as a volume, where each file corresponds to a Vault entry
RobbySingh
changed the title
RobbySingh
changed the title
nemacysts
reviewed
Jul 21, 2023
- Used a context manager for temporarily setting vault credentials - Several python magic upgrades - Added sample return types for data - Changed default parameters to required for dstore/creds - Few refactors
RobbySingh
commented
Jul 24, 2023
|
I ran a fresh make setup-kubernetes-job with the vault credentials set in etc_paasta_playground.vault.json under database_credentials_vault_env_overrides (just vault_addr_override and vault_token_override) and confirmed that the env worked as expected |
mattmb
requested changes
Jul 25, 2023
nemacysts
reviewed
Aug 1, 2023
nemacysts
reviewed
Aug 2, 2023
- Changed database and dstore -> datastore for clarity
- set_env always resets the environ later, so it should instead be renamed to reflect this
nemacysts
reviewed
Aug 3, 2023
jfongatyelp
reviewed
Aug 3, 2023
- Although we didn't specify cassandra here (since we don't know yet), we add additional_properties = True to suffice
RobbySingh
commented
Aug 3, 2023
- Having one volume with keys + paths as items from SecretSource allows us to get the same effect - Refactored time.sleep in tests and secrets_sync - Fixed test cases to match
nemacysts
reviewed
Aug 4, 2023
RobbySingh
commented
Aug 4, 2023
nemacysts
reviewed
Aug 9, 2023
Co-authored-by: Luis Pérez <[email protected]>
- Shortened volume name for datastores
…ased-mysql-password-rotation
jfongatyelp
reviewed
Aug 10, 2023
- Corrected 'help' for --secret-type call
RobbySingh
commented
Aug 10, 2023
nemacysts
approved these changes
Aug 14, 2023
ilkinmammadzada
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fluffy.yelpcorp.com/i/67hDPrWrG31CtcZRZf0RB17HqJg8XqXZ.html
Pasting in fluffy for security reasons
(updated Aug 9, 2023 @ 1:46pm)