COMPINFRA-2938: Support security-check in parallel steps #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
Jul 28, 2023
jfongatyelp
force-pushed
the
u/jfong/check_support_parallel_step
branch
from
57ac049
to
b997246
Compare
KaspariK
approved these changes
Jul 28, 2023
nemacysts
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added
parallelstep support todeploy.yaml,paasta checkhas been complaining about pipelines that run thesecurity-checkin parallel with anything else (which is actually what we provide as a default nowadays!).This updates
paasta checkto now also look at parallel steps to verify we have a security-check step, along with a test to verify.