Add paasta status for vitesscluster and mount /nail/etc/srv-configs to VTTablets #3902
Conversation
VinaySagarGonabavi
requested review from
nemacysts,
jfongatyelp,
flopex,
matt-ullmer and
alexanderjulianmartinez
| class EtcdLockServerStatus(TypedDict, total=False): | ||
| observedGeneration: int | ||
| available: str | ||
| clientServiceName: str |
There was a problem hiding this comment.
Side question about this -- on EKS we don't actually have direct access to the etcd cluster, is this still used? How is the etcd lock implemented?
There was a problem hiding this comment.
We're using only zk implementation of lock server, but the status returns this field and hence created to accommodate it. This is expected to be unused and return an empty value
There was a problem hiding this comment.
the typeddicts are non-total so we could always leave them out :)
| class EtcdLockServerStatus(TypedDict, total=False): | ||
| observedGeneration: int | ||
| available: str | ||
| clientServiceName: str |
There was a problem hiding this comment.
the typeddicts are non-total so we could always leave them out :)
| status: VitessClusterStatus = vitess_status.get("status") | ||
| if status is None: | ||
| output.append( | ||
| PaastaColors.red("indent * tab + Vitess cluster is not available yet") |
There was a problem hiding this comment.
should this be something like: PaastaColors.red(indent * tab + "Vitess cluster is not available yet")?
| + str(status.get("observedGeneration", 0)) | ||
| ) | ||
| output.append( | ||
| indent * tab + "Gateway Service Name: " + status.get("gatewayServiceName", "") |
There was a problem hiding this comment.
not sure if this can happen, but might be nice to have a default like UNKNOWN or something to make it clearer that something is missing :)
| output.append( | ||
| indent * tab + "Cells: " + PaastaColors.red("No cell status available") | ||
| ) | ||
| return 0 |
There was a problem hiding this comment.
just to confirm: for each of these sections, we can't proceed with the subsequent sections if the current one is unavailable?
| orphanedKeyspaces: Dict[str, OrphanStatus] | ||
|
|
||
|
|
||
| def print_vitess_status( |
There was a problem hiding this comment.
might be a useful refactor in the future to break each of the sections into their own function so that print_vitess_status() isn't so long
Testing setup:
Testing output:
VitessClusterStatus (https://github.com/planetscale/vitess-operator/blob/main/docs/api.md#vitessclusterstatus) and its fields used as a reference for TypedDicts added