Attempt #2 MLCOMPUTE-1203 | Configure Spark driver pod memory and cores based on Spark args #3903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 10, 2024 18:34
… and mem configs for Spark drivers on k8s
…E-1203_fix_spark_driver_resources
…E-1203_fix_spark_driver_resources
…E-1203_fix_spark_driver_resources
…Config constructor
CaptainSame
changed the title
nemacysts
reviewed
Jun 27, 2024
added 6 commits
June 27, 2024 18:48
…E-1203_fix_spark_driver_resources
chi-yelp
approved these changes
Jun 28, 2024
|
Also verified with: |
nemacysts
reviewed
Jun 28, 2024
This reverts commit 5d27b1b.
…instance configs" This reverts commit 45f7b4a.
…instance configs" This reverts commit 01e43d4.
Depending on merge order, we'll want to slightly refactor this after #3906 if this goes out first (or refactor this before merging if #3906 goes out first) - but this makes it so that we never create SAs in Tron outside of setup_tron_namespace (which will get called from a host that has the correct permissions) This avoids needing to pass around any dry-run/validation flags :)
i blame copilot for letting me turn off my brain
i wish that we didn't pass around a huge string
…into MLCOMPUTE-1203_fix_spark_driver_resources
…ix_spark_driver_resources
|
lgtm - probably want someone from ML Compute to re-ship since i added a couple commits after working with @EvanKrall to refactor things a bit :) |
…E-1203_fix_spark_driver_resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #3892
+
DAR-2360 | pass
for_validationflag correctly for paasta validate flows