SEC-19137 Add additional get_aws_credentials tests to spark-run
#3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainSame
reviewed
Jul 16, 2024
tests/cli/test_cmds_spark_run.py
Outdated
| @mock.patch("service_configuration_lib.spark_config.Session", autospec=True) | ||
| def test_get_aws_credentials_session(mock_boto3_session, mock_use_aws_profile): | ||
| # prioritize session over `profile_name` if both are provided | ||
| from service_configuration_lib.spark_config import get_aws_credentials |
There was a problem hiding this comment.
Any reason to not have imports at the top? LGTM otherwise
There was a problem hiding this comment.
Moved all the import statements!
Qmando
approved these changes
Jul 18, 2024
Co-authored-by: Sameer Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗️Must be merged after #3901
Add tests to spark-run to make sure
get_aws_credentials()fromservice_configuration_libis invoked properly by the various flags passed topaasta spark-run:--serviceshould not overwrite--aws-profile--serviceif--aws-profileis absent--serviceand--aws-profile, use--aws-profile=default