MLCOMPUTE-1389 | remove spark.app.id and generate static spark.app.name #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 18, 2024 11:33
…E-1389_generate_static_configs
nemacysts
approved these changes
Jul 18, 2024
| spark_conf.pop("spark.app.id", None) | ||
| # use a static spark.app.name to prevent frequent config updates in Tron. | ||
| # md5 and base64 will always generate the same encoding for a string. | ||
| # This spark.app.name might be overridden by yelp spark-submit wrapper. |
There was a problem hiding this comment.
from a sourcegraph search for repo:^sysgit/yelpsoa-configs$ spark.app.name it seems like some folks set short static app names, so we may want to follow this up with a follow-up PR that allows static/user-set app names to continue being set if that's something we want to support
There was a problem hiding this comment.
It's also auto set by spark-etl jobs - sourcegraph: repo:spark_etl$ spark.app.name
chi-yelp
approved these changes
Jul 18, 2024
added 3 commits
July 22, 2024 18:13
nemacysts
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spark.app.idis generated fresh and added by service_configuration_lib with a random postfix because of which Tron keeps running update config flow every few minutes. This config should be removed and generated by yelp spark-submit wrapper or by Spark itself.spark.app.nameis also generated fresh with a random timestamp and postfix which leads to the same problem. This config should be made static and potentially replaced by yelp spark-submit wrapper later