MLCOMPUTE-1497 | include spark driver memory overhead in driver pod memory #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CaptainSame
commented
Aug 5, 2024
•
CaptainSame
commented
- Spark driver pod memory needs to allocate memory for driver memory overhead config along with the driver memory config
chi-yelp
reviewed
Aug 5, 2024
chi-yelp
reviewed
Aug 5, 2024
chi-yelp
reviewed
Aug 5, 2024
nemacysts
approved these changes
Aug 5, 2024
| @@ -445,7 +445,7 @@ | |||
| "type": "boolean" | |||
| }, | |||
| "spark.app.name": { | |||
| "type": "boolean" | |||
| "type": "string" | |||
There was a problem hiding this comment.
nice-to-have suggestion: might be worth adding some additional constraints here too re: min/max length since (iirc) this gets turned into a k8s label and those values have a max length (and if there's any characters that are not allowed, there's a field for adding a pattern that these strings need to match to pass validation)
chi-yelp
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.