Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the timestamps errors in the failed tests #3942

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Fix the timestamps errors in the failed tests #3942

merged 3 commits into from
Sep 3, 2024

Conversation

EmanElsaban
Copy link
Contributor

@EmanElsaban EmanElsaban commented Aug 30, 2024 •
edited
Loading

These tests were failing due to difference in timestamps. This PR fixes the timestamps to match the expected ones

nemacysts
nemacysts approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm a little confused as to how these started failing in the first place since all the time stuff should be mocked 🤔

@EmanElsaban EmanElsaban merged commit eed085b into master Sep 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piax93 piax93 piax93 approved these changes

@wilmer05 wilmer05 wilmer05 approved these changes

@nemacysts nemacysts Awaiting requested review from nemacysts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmanElsaban @nemacysts @wilmer05 @piax93