Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional endpoint schema #3955

Merged
merged 2 commits into from
Sep 11, 2024
Merged

additional endpoint schema #3955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
238303f
additional endpoint schema
ahaswell Sep 11, 2024
344ac7f
remove namespace_alert
ahaswell Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/source/yelpsoa_configs.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,7 +1088,6 @@ These keys provide optional overrides for the default alerting behaviour.
page_nonprod: true
error_threshold_ratio: 0.02
minimum_error_rps: 10
namespace_alert: false
endpoints:
- name: GET /something
- name: GET /something/else
Expand All @@ -1110,8 +1109,6 @@ These keys provide optional overrides for the default alerting behaviour.
environments. Defaults to **false**.
- ``error_threshold_ratio``: Error threshold ratio (0-1). Defaults to **0.01**.
- ``minimum_error_rps``: Minimum error rate per second, minimum is zero. Defaults to **5**.
- ``namespace_alert``: Toggle namespace alerting. Defaults to **true**. Can be used to disable alerting for the
namespace when alerts are configured for specific endpoints.
- ``endpoints``: List of endpoints to create alerts for.
- ``name``: The name of the endpoint.
- ``error_threshold_ratio``: Error threshold ratio (0-1). If not specified the threshold will be inherited from the parent.
Expand Down
21 changes: 18 additions & 3 deletions paasta_tools/cli/schemas/smartstack_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@
"type": "integer",
"minimum": 0
},
"namespace_alert": {
"type": "boolean"
},
"endpoints": {
"type": "array",
"items": {
Expand All @@ -273,6 +270,24 @@
"type": "number",
"minimum": 0,
"maximum": 1
},
"team": {
"type": "string"
},
"slack_channel": {
"type": "string"
},
"project": {
"type": "string"
},
"ticket": {
"type": "boolean"
},
"page": {
"type": "boolean"
},
"page_nonprod": {
"type": "boolean"
}
},
"required": [
Expand Down
Loading