Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use datetime.now(timezone.utc) in paasta status #3963

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Always use datetime.now(timezone.utc) in paasta status #3963

merged 4 commits into from
Sep 20, 2024

Commits on Sep 18, 2024

  1. Always use datetime.now(timezone.utc) in paasta status 

    This will make it clear that we're always using UTC internally and
avoids the footgun of using utcnow()

I've verified that the output for warming up pods is still the same in
both this version of the code as well as in status quo - as well as the
same for flink and kafka workloads
    @nemacysts
    nemacysts committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    591e3d9 View commit details
    Browse the repository at this point in the history

  2. forgot to update recent_container_restart

    @nemacysts
    nemacysts committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d062095 View commit details
    Browse the repository at this point in the history

  3. Also explictly use UTC in event filtering logic

    @nemacysts
    nemacysts committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    629e89b View commit details
    Browse the repository at this point in the history

  4. Update kafka tests to account for tz offset 

    This is probably better than the previous output where it was unclear
what offset the times were in without looking at the parenthentical
humanized time
    @nemacysts
    nemacysts committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6a439da View commit details
    Browse the repository at this point in the history