Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update smartstack_schema.json to support minimum_error_rps for error alerting #3969

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Update smartstack_schema.json to support minimum_error_rps for error alerting #3969

merged 1 commit into from
Sep 24, 2024

Conversation

andrewli611
Copy link
Contributor

Update smartstack_schema.json to support minimum_error_rps for error alerting

@andrewli611 andrewli611 requested a review from a team as a code owner September 23, 2024 14:57
jfongatyelp
jfongatyelp approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jfongatyelp jfongatyelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing eventually these top-level keys & endpoint overrides could be in a definition so we don't have to repeat ourselves, but no need to block on that right now!

@nemacysts nemacysts merged commit 3e45742 into Yelp:master Sep 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejoycekung thejoycekung thejoycekung approved these changes

@jfongatyelp jfongatyelp jfongatyelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewli611 @jfongatyelp @thejoycekung @nemacysts