allow loading decoupled config from url #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out a bit convoluted, mostly due to wanting to keep the existing configuration watcher setup as is.
In simple terms, the custom YAML loader we already employed for combining multiple files together, now can also lunch a background thread which periodically checks a URL for updated configuration values. It shuffles around data in poorly managed temporary files to achieve that, but I'm not too worried about leaving behind garbage, as this is mostly aimed for when running in containers.
I tested a modified version of our currently deployed config with an S3 url directly plugged into it, and all seems to be fine.