Skip to content

Commit

Permalink
Fix readded comment after pulling master
Browse files Browse the repository at this point in the history
  • Loading branch information
jfongatyelp committed Jul 9, 2024
1 parent 38a0372 commit 28b3f7a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions task_processing/plugins/kubernetes/kubernetes_pod_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -662,9 +662,6 @@ def kill(self, task_id: str) -> bool:
This function will request that Kubernetes delete the named Pod and will return
True if the Pod termination request was succesfully emitted or False otherwise.
"""
# NOTE: we're purposely not removing this task from `task_metadata` as we want
# to handle that with the Watch that we'll set to monitor each Pod for events.
# TODO(TASKPROC-242): actually handle termination events
terminated = any(
kube_client.terminate_pod(
namespace=self.namespace,
Expand Down

0 comments on commit 28b3f7a

Please sign in to comment.