Skip to content

Commit

Permalink
Commenting this test now as its timing out the github actions
Browse files Browse the repository at this point in the history
  • Loading branch information
EmanElsaban committed Jul 23, 2024
1 parent 70ac256 commit 87f121b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
6 changes: 3 additions & 3 deletions task_processing/plugins/kubernetes/kubernetes_pod_executor.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import logging
import multiprocessing
import queue
import time
from multiprocessing import JoinableQueue
from queue import Queue
from typing import Collection
from typing import Optional
Expand All @@ -17,8 +19,6 @@
from kubernetes.client import V1SecurityContext
from kubernetes.client.exceptions import ApiException
from pyrsistent import pmap
import multiprocessing
from multiprocessing import JoinableQueue
from pyrsistent import v
from pyrsistent.typing import PMap

Expand Down Expand Up @@ -113,7 +113,7 @@ def __init__(
# possible to cleanly shutdown both of these.
self.pending_events: "JoinableQueue[PodEvent]" = JoinableQueue()
self.event_queue: "JoinableQueue[Event]" = JoinableQueue()

# TODO(TASKPROC-243): keep track of resourceVersion so that we can continue event processing
# from where we left off on restarts
self.pod_event_watch_processes = []
Expand Down
7 changes: 4 additions & 3 deletions tests/unit/conftest.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import threading
import multiprocessing
import threading

import mock
import pytest
Expand All @@ -16,7 +16,8 @@ def mock_Thread():
with mock.patch.object(threading, "Thread") as mock_Thread:
yield mock_Thread


@pytest.fixture
def mock_Process():
with mock.patch.object(multiprocessing, 'Process') as mock_Process:
yield mock_Process
with mock.patch.object(multiprocessing, "Process") as mock_Process:
yield mock_Process
5 changes: 3 additions & 2 deletions tests/unit/plugins/kubernetes/kubernetes_pod_executor_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -802,8 +802,8 @@ def test_process_event_enqueues_task_processing_events_no_state_transition(
assert (
len(k8s_executor.task_metadata[mock_pod.metadata.name].task_state_history) == 0
)


def test_pending_event_processing_loop_processes_remaining_events_after_stop(
k8s_executor,
):
Expand All @@ -812,6 +812,7 @@ def test_pending_event_processing_loop_processes_remaining_events_after_stop(
test_pod = V1Pod(
metadata=V1ObjectMeta(
name="test-pod",
namespace="task_processing_tests",
)
# Add other necessary attributes here
)
Expand Down

0 comments on commit 87f121b

Please sign in to comment.