Skip to content

Commit

Permalink
Add pull request template
Browse files Browse the repository at this point in the history
Mostly as I have a tendency to forget to change the target branch to the oldest supported version for a PR when I haven't worked on this repo for a little while ... oops...

Let's hope this reminder will help prevent such snafus in the future.

Includes a tweak to the Remark config as the file name of the template needs to comply with the requirements by GitHub for such templates and this conflicts with the file name expectations set by Remark (by default).

Ref: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
  • Loading branch information
jrfnl committed Jan 7, 2025
1 parent 0bf686b commit 8b36f38
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<!--
REMINDER: Please target the **oldest** branch of the PHPUnit Polyfills that is affected by this issue.
-->
2 changes: 1 addition & 1 deletion .remarkrc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"remark-lint-no-duplicate-definitions",
"remark-lint-no-empty-url",
"remark-lint-no-file-name-consecutive-dashes",
"remark-lint-no-file-name-irregular-characters",
["remark-lint-no-file-name-irregular-characters", "\\.a-zA-Z0-9-_"],
"remark-lint-no-file-name-outer-dashes",
"remark-lint-no-heading-like-paragraph",
"remark-lint-no-literal-urls",
Expand Down

0 comments on commit 8b36f38

Please sign in to comment.