4.0 | Drop support for PHP < 7.1 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Composer version requirements. * Remove PHP 7.0 specific Composer script. * Stop running tests/linting in CI against PHP 7.0.
Remove various in-code work-arounds which were specifically to support PHP 7.0.
Remove the PHP 7.1+ specific test fixtures for the `AssertObjectEquals` and `AssertObjectNotEquals` tests. As support for PHP < 7.1 has been dropped, these fixture methods no longer need their own class and can be moved into the main test fixture.
jrfnl
force-pushed
the
4.0/feature/drop-support-for-php-lt-7.1
branch
from
40ceca3 to
f800be8
Compare
|
Thanks for reviewing @hellofromtonya ! Want to do the honours ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for PHP < 7.1 [1]
Drop support for PHP < 7.1 [2]
Remove various in-code work-arounds which were specifically to support PHP 7.0.
Drop support for PHP < 7.1 [3]
Remove the PHP 7.1+ specific test fixtures for the
AssertObjectEqualsandAssertObjectNotEqualstests.As support for PHP < 7.1 has been dropped, these fixture methods no longer need their own class and can be moved into the main test fixture.