4.0 | Drop support for PHPUnit < 7.5 #239
Conversation
Adjust CI, README and `composer.json` for the drop of support for PHPUnit < 7.5.0. The 7.5.0 version is a deliberate choice to allow for dropping all PHPUnit 7.x related polyfills.
|
FYI: Coveralls will probably "block" the PR, but that will work itself out with the follow-up PRs/commits for the PHPUnit < 7.5 version drop. Alternatively, if we want to be sure, I can pull the other PRs first and we could leave this one for last. |
Hmm, might be better to pull the other PRs first to ensure the CI is passing before merge. |
Just checked - that won't work as the tests won't pass in that case as they would still be run against PHPUnit 6.x and I'd be removing things needed to get the tests to pass on PHPUnit 6.x. Darn... update the PR to include all six commits ? |
I was thinking the same thing. Yes, one PR with all of the commits. |
Remove the `AssertIsType` polyfill and all references to it. Includes updating example code about using the polyfills in the README.
Remove the `AssertStringContains` polyfill and all references to it.
Remove the `AssertEqualsSpecializations` polyfill and all references to it.
Remove in-code work-arounds which were in place to support PHPUnit < 7.5.0.
jrfnl
changed the title
jrfnl
changed the title
Done. Including updating the PR description to match. |
|
Not as big as I expected: |
Even though the TestListener implementation is not (yet) compatible with PHPUnit 10 (nor 11 or 12), we should still drop support for PHPUnit < 7.5 from the existing implementation. This includes: * Dropping support for the PHPUnit 6 specific implementation of the TestListener. * Removing the semi-duplicate test fixture classes for PHPUnit < 7, as well as removing the test helper method containing the toggle for which fixture to use. * Updating the documentation in the README.
jrfnl
force-pushed
the
feature/drop-support-for-phpunit-lt-7.5-1
branch
from
9c679ec to
1dcba37
Compare
Drop support for PHPUnit < 7.5 [1]
Adjust CI, README and
composer.jsonfor the drop of support for PHPUnit < 7.5.0.The 7.5.0 version is a deliberate choice to allow for dropping all PHPUnit 7.x related polyfills.
Drop support for PHPUnit < 7.5 [2]
Remove the
AssertIsTypepolyfill and all references to it.Includes updating example code about using the polyfills in the README.
Drop support for PHPUnit < 7.5 [3]
Remove the
AssertStringContainspolyfill and all references to it.Drop support for PHPUnit < 7.5 [4]
Remove the
AssertEqualsSpecializationspolyfill and all references to it.Drop support for PHPUnit < 7.5 [5]
Remove in-code work-arounds which were in place to support PHPUnit < 7.5.0.
Drop support for PHPUnit < 7.5 [6]
Even though the TestListener implementation is not (yet) compatible with PHPUnit 10 (nor 11 or 12), we should still drop support for PHPUnit < 7.5 from the existing implementation.
This includes: