-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1-1277 - Implement tooling standards in js package #18319
Merged
igorschoester
merged 14 commits into
trunk
from
P1-1277-implement-es-lint-babel-tooling-standards-in-js-package
Apr 11, 2022
Merged
P1-1277 - Implement tooling standards in js package #18319
igorschoester
merged 14 commits into
trunk
from
P1-1277-implement-es-lint-babel-tooling-standards-in-js-package
Apr 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
538fe2e
to
ddac01e
Compare
Removes unused exported variables
File copies over at the time of install. Using a version makes it a symlink because of the workspace. That seems preferable, and a must if we work on the packages.
After some discussion: no need to build this package by itself. We can rely on the root webpack build for production too.
04549e0
to
607ac76
Compare
igorschoester
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR & ACC ✅
Changed the approach after some discussion: no more babel build for JS package specifically. Due to it being the root JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
js
package@yoast/babel-preset
,eslint-config-yoast
,@yoast/jest-preset
and@yoast/browserslist-config
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Use the transpiled code only on production buildRunning the build command from the 'js' package on every file change when using i.e the watch command would negatively impact the development speed drastically.jsSrc
andcssDist
fromconfig/webpack/paths.js
because they were unused.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
packages/js
and runyarn lint
141 warnings
packages/js
and runyarn test
Test Suites: 55 passed
without any errorsTest instructions for QA when the code is in the RC
QA can test this PR by following these steps:
grunt build
,grunt artifact
andyarn lint
still work as expected.Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Fixes P1-1277