-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors the SparklesIcon for reusability #21449
Merged
Jordi-PV
merged 7 commits into
feature/fix-assessments
from
224-create-an-element-badge-to-show-a-counter-on-top-of-the-ai-toast--modal
Jun 28, 2024
Merged
Refactors the SparklesIcon for reusability #21449
Jordi-PV
merged 7 commits into
feature/fix-assessments
from
224-create-an-element-badge-to-show-a-counter-on-top-of-the-ai-toast--modal
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraja-pro
added
the
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
label
Jun 21, 2024
@mhkuu Please be aware that following packages have been abandoned and are not actively maintained anymore:
Please consider using the other packages instead. |
…ge-to-show-a-counter-on-top-of-the-ai-toast--modal
…seo into 224-create-an-element-badge-to-show-a-counter-on-top-of-the-ai-toast--modal
Pull Request Test Coverage Report for Build afd819a049a542d72e22388849bbcac4594c0f3fDetails
💛 - Coveralls |
@vraja-pro Great job, I'll merge it! 👌 I agree that the gradient id should be within the scope of the component itself, I do not know why it was in the parent component 😓 |
Jordi-PV
deleted the
224-create-an-element-badge-to-show-a-counter-on-top-of-the-ai-toast--modal
branch
June 28, 2024 09:34
mhkuu
changed the title
224 create an element badge to show a counter on top of the ai toast modal
Refactors the SparklesIcon for reusability
Jul 1, 2024
18 tasks
mhkuu
added
the
innovation
Innovative issue. Relating to performance, memory or data-flow.
label
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
innovation
Innovative issue. Relating to performance, memory or data-flow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
SparklesIcon
.Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes Create an element (Badge?) to show a counter on top of the AI Toast / Modal